-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[Jetlagged] Update icons and remove material icons dependency #1590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit replaces the Material Icons dependency with local drawable resources for all icons used in the JetLagged sample. This involves: - Adding new vector drawable XML files for each icon (`ic_bedtime.xml`, `ic_home.xml`, `ic_leaderboard.xml`, `ic_menu.xml`, `ic_settings.xml`, `ic_single_bed.xml`, `ic_watch.xml`). - Updating composable functions in `HomeScreenCards.kt`, `JetLaggedHeader.kt`, and `JetLaggedDrawer.kt` to use `painterResource` for loading these local drawables instead of relying on the `Icons` object from the material-icons-extended library. - Removing the `androidx.compose.material.iconsExtended` dependency from the app's `build.gradle.kts` file. - Modifying the `Screen` enum in `JetLaggedDrawer.kt` to use `Int` (drawable resource ID) for the icon property instead of `ImageVector`. - Changing the `icon` parameter type in `TwoLineInfoCard` from `ImageVector` to `Int`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @JolandaVerhoef, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly refactors the icon management within the JetLagged sample application. The primary goal is to remove the external dependency on the Material Icons library by migrating all used icons to local vector drawable resources. This change streamlines the asset pipeline, potentially reduces app size, and provides greater control over icon customization.
Highlights
- Dependency Removal: The
androidx.compose.material.iconsExtended
dependency has been removed from the project'sbuild.gradle.kts
file, reducing the application's external dependencies. - Local Icon Migration: All icons previously sourced from Material Icons have been replaced with local vector drawable XML files. New drawable resources (
ic_bedtime.xml
,ic_home.xml
,ic_leaderboard.xml
,ic_menu.xml
,ic_settings.xml
,ic_single_bed.xml
,ic_watch.xml
) have been added to theres/drawable
directory. - Composable Function Updates: Composable functions in
HomeScreenCards.kt
,JetLaggedHeader.kt
, andJetLaggedDrawer.kt
have been updated to load icons usingpainterResource
with the new local drawable resource IDs, instead of relying onImageVector
objects from the Material Icons library. - Type Refactoring: The
icon
property in theScreen
enum withinJetLaggedDrawer.kt
and theicon
parameter in theTwoLineInfoCard
composable inHomeScreenCards.kt
have been changed fromImageVector
toInt
to accommodate the use of drawable resource IDs.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request replaces the Material Icons dependency with local vector drawables. Consider using @DrawableRes
annotations for type safety and removing hardcoded fillColor
from the new vector drawables to ensure they are tintable and compatible with different themes.
JetLagged/app/src/main/java/com/example/jetlagged/HomeScreenCards.kt
Outdated
Show resolved
Hide resolved
JetLagged/app/src/main/java/com/example/jetlagged/JetLaggedDrawer.kt
Outdated
Show resolved
Hide resolved
…wer.kt Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…rds.kt Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR replaces the Material Icons dependency with local drawable resources for all icons used in the JetLagged sample.
This involves:
ic_bedtime.xml
,ic_home.xml
,ic_leaderboard.xml
,ic_menu.xml
,ic_settings.xml
,ic_single_bed.xml
,ic_watch.xml
).HomeScreenCards.kt
,JetLaggedHeader.kt
, andJetLaggedDrawer.kt
to usepainterResource
for loading these local drawables instead of relying on theIcons
object from the material-icons-extended library.androidx.compose.material.iconsExtended
dependency from the app'sbuild.gradle.kts
file.Screen
enum inJetLaggedDrawer.kt
to useInt
(drawable resource ID) for the icon property instead ofImageVector
.icon
parameter type inTwoLineInfoCard
fromImageVector
toInt
.