Skip to content

Conversation

rayworks
Copy link
Contributor

Fix #1182

@rayworks rayworks requested a review from a team as a code owner September 13, 2023 09:45
@rayworks rayworks requested a review from mlykotom September 13, 2023 09:45
@mlykotom
Copy link
Contributor

I think in this case it's fine, since we only have very small amount of horizontal items. However, how would you approach it, if you had a lot of items and you'd need to keep LazyRow?

@rayworks
Copy link
Contributor Author

@mlykotom Yeap, I think you're right. If we had plenty of items, LazyRow should be the option, considering the list performance. And I'd like to set the max height for the dynamic text (maybe maxLines?) instead of maintaining and updating the max item height along the way.

@mlykotom
Copy link
Contributor

There's a failed thest related to the change. Pls could you fix it?

@rayworks
Copy link
Contributor Author

There's a failed test related to the change. Pls could you fix it?

Sure, just fixed it.

@mlykotom mlykotom merged commit 7eaaae6 into android:main Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Truncated text found at the bottom of the card
2 participants