[Crane] Implement updates to transition animation api under Crane's Home screen #1167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlykotom
requested changes
Jul 25, 2023
Comment on lines
42
to
43
| <string name="tint_transition_spec">tintTransitionSpec</string> | ||
| <string name="tint_transition">tintTransition</string> |
There was a problem hiding this comment.
This doesn't have to be part of the strings.xml as this information is just for the tooling, not for the app.
You can just keep the strings directly in the code.
…ld and added the strings directly in the code.
mlykotom
approved these changes
Jul 25, 2023
mlykotom
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** The label parameter was added to color animation transitions for the non-editable input field on the Home screen. Adding this label makes it easier to inspect this transition in the Animation Preview.
** Replaced the experimental “with” extension function used alongside the fade-in animation with the stable “togetherWith” function.
No major logic was altered.