[Jetsurvey] Changed to use Navigation Compose #1059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
IanGClifton
force-pushed
the
iangclifton/composenav
branch
from
ace160e to
c77fb01
Compare
This eliminates all fragments in favor of navigating at the composable level. I also updated the screen-level composables to take in explicit lambdas rather than event handlers to follow best practices. One notable change here is that there is no longer a fragment from which to launch the camera. Instead, the PhotoQuestion uses rememberLauncherForActivityResult and selfies are now stored in the app's cache directory, which means no file permission is required.
IanGClifton
force-pushed
the
iangclifton/composenav
branch
from
c77fb01 to
d557d6a
Compare
IanGClifton
changed the title
arriolac
reviewed
Feb 16, 2023
| val welcomeViewModel: WelcomeViewModel = viewModel(factory = WelcomeViewModelFactory()) | ||
| WelcomeScreen( | ||
| onSignInSignUp = { email -> | ||
| welcomeViewModel.handleContinue( |
There was a problem hiding this comment.
Should this logic should be handled within WelcomeScreen and JetsurveyNavHost? This way, JetsurveyNavHost is only concerned with navigation events (i.e. once sign in/up completes and ViewModels would only be scoped within individual screens. Same comment for other screens.
There was a problem hiding this comment.
That makes sense. I'll create a route composable for each route that has the logic for getting the view model and any setup needed for the individual screen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates all fragments in favor of navigating at the composable
level. I also updated the screen-level composables to take in explicit
lambdas rather than event handlers to follow best practices.
One notable change here is that there is no longer a fragment from which
to launch the camera. Instead, the PhotoQuestion uses
rememberLauncherForActivityResult and selfies are now stored in the
app's cache directory, which means no file permission is required.
Fixes #1038