Skip to content

Conversation

@dhayab
Copy link
Member

@dhayab dhayab commented Sep 10, 2025

Summary

#1323 aimed to pause the loading icon animation to prevent performance issues in Safari, but while it worked well after user interaction, it didn't pause it on initial load. This was because the request to pause the animations was done before the element was added to the DOM. This PR adds that behavior.

closes #1322 more

@dhayab dhayab requested review from a team, Haroenv and aymeric-giraudet and removed request for a team September 10, 2025 13:47
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 10, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit eac542d:

Sandbox Source
@algolia/autocomplete-example-github-repositories-custom-plugin Configuration
@algolia/autocomplete-example-instantsearch Configuration
@algolia/autocomplete-example-playground Configuration
@algolia/autocomplete-example-preview-panel-in-modal Configuration
@algolia/autocomplete-example-starter-algolia Configuration
@algolia/autocomplete-example-starter Configuration
@algolia/autocomplete-example-reshape Configuration
@algolia/autocomplete-example-vue Configuration

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change makes sense to me, just a little bit more conditions needed

@dhayab dhayab requested a review from Haroenv September 10, 2025 14:29
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?. would also be fine

@dhayab
Copy link
Member Author

dhayab commented Sep 10, 2025

?. would also be fine

I started with this, but I preferred not invoking the function n times at all in that case.

@dhayab dhayab merged commit 939db17 into next Sep 10, 2025
10 checks passed
@dhayab dhayab deleted the fix/pause-loading-icon-animation branch September 10, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Continuous style recalculations and high CPU usage in Safari

3 participants