-
Notifications
You must be signed in to change notification settings - Fork 23
feat(specs): add lastUpdatedAt to personalization real-time user #5126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noice
@@ -13,6 +14,8 @@ RealtimeUser: | |||
userID: | |||
type: string | |||
description: User ID of the user. | |||
lastUpdatedAt: | |||
type: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
usually we add the format it's useful for languages that need to parse it .e.g Golang
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 addressed in 6e7f754
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can go further with this: https://swagger.io/docs/specification/v3_0/data-models/data-types/#strings
type: string | |
type: string | |
format: date-time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we purposely not use date-time because it forces the user to construct objects (e.g. new Date()), in some languages it's a lot of overhead
…) (generated) [skip ci] Co-authored-by: Raed <[email protected]>
…erated) algolia/api-clients-automation#5126 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Raed <[email protected]>
🧭 What and Why
Add
lastUpdatedAt
property to Advanced-Personalization Real-time user response.