Skip to content

Conversation

raed667
Copy link
Contributor

@raed667 raed667 commented Jul 17, 2025

🧭 What and Why

Add lastUpdatedAt property to Advanced-Personalization Real-time user response.

@raed667 raed667 requested a review from bengreenbank July 17, 2025 08:26
@raed667 raed667 requested a review from a team as a code owner July 17, 2025 08:26
@raed667 raed667 requested review from millotp and shortcuts July 17, 2025 08:26
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 17, 2025

✔️ Code generated!

Name Link
🪓 Triggered by 59a2871b536ba168651118420bf38a329b504e73
🍃 Generated commit bc1ed20179ed7a1a86893963eb251252818546f3
🌲 Generated branch generated/feat/predict/update-real-time-profile
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1771
javascript 1591
php 1536
csharp 1261
python 1094
java 1074
ruby 818
swift 729
scala 23

shortcuts
shortcuts previously approved these changes Jul 17, 2025
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

@@ -13,6 +14,8 @@ RealtimeUser:
userID:
type: string
description: User ID of the user.
lastUpdatedAt:
type: string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usually we add the format it's useful for languages that need to parse it .e.g Golang

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 addressed in 6e7f754

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can go further with this: https://swagger.io/docs/specification/v3_0/data-models/data-types/#strings

Suggested change
type: string
type: string
format: date-time

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we purposely not use date-time because it forces the user to construct objects (e.g. new Date()), in some languages it's a lot of overhead

@raed667 raed667 changed the title feat(predict): add lastUpdatedAt to real-time user feat(specs): add lastUpdatedAt to personalization real-time user Jul 17, 2025
@shortcuts shortcuts merged commit 2ee13af into main Jul 17, 2025
29 of 30 checks passed
@shortcuts shortcuts deleted the feat/predict/update-real-time-profile branch July 17, 2025 09:34
algolia-bot added a commit that referenced this pull request Jul 17, 2025
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants