Skip to content

bugfix: break reader loop if BoxHeader is size zero to prevent dead-loop #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 24, 2021
Merged

bugfix: break reader loop if BoxHeader is size zero to prevent dead-loop #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/reader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@ impl<R: Read + Seek> Mp4Reader<R> {
let header = BoxHeader::read(&mut reader)?;
let BoxHeader { name, size: s } = header;

// Break if size zero BoxHeader, which can result in dead-loop.
if s == 0 {
break;
}

// Match and parse the atom boxes.
match name {
BoxType::FtypBox => {
Expand Down