Skip to content

Feature/writebox trait #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 28, 2020
Merged

Feature/writebox trait #11

merged 11 commits into from
Jul 28, 2020

Conversation

ian-spoonradio
Copy link
Contributor

  • Add Mp4Box trait that share the common behavior of MP4 box.
  • Add WriteBox trait that share the same behavior of read-box().
  • Implement WriteBox trait for all boxes except StsdBox.
  • Improve compatibility with large boxes.

alfg
alfg approved these changes Jul 28, 2020
View reviewed changes
Copy link
Owner

@alfg alfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you for your contributions! 😄

Before I merge, will you be able to provide an example program for the writebox trait feature?

@alfg alfg merged commit 8f56200 into alfg:master Jul 28, 2020
@ian-spoonradio ian-spoonradio deleted the feature/writebox-trait branch July 29, 2020 00:59
jprochazk pushed a commit to jprochazk/mp4 that referenced this pull request Sep 18, 2024
@ian-spoonradio @unipro
Feature/writebox trait (alfg#11)
9aa0472 
* Add ReadBox trait

* Add boxtype macro

* Remove offset in BoxHeader

* Fix parsing error when box has largesize

* Remove duplicated codes reading version and flags

* Simplify all box size types as largesize

* Add WriteBox trait and improve compatibility with large box

* Split large atoms file into smaller ones

* Refator Error

Co-authored-by: Byungwan Jun <[email protected]>
CandleCandle pushed a commit to CandleCandle/mp4-rust that referenced this pull request May 7, 2025
@ian-spoonradio @unipro
Feature/writebox trait (alfg#11)
833e852 
* Add ReadBox trait

* Add boxtype macro

* Remove offset in BoxHeader

* Fix parsing error when box has largesize

* Remove duplicated codes reading version and flags

* Simplify all box size types as largesize

* Add WriteBox trait and improve compatibility with large box

* Split large atoms file into smaller ones

* Refator Error

Co-authored-by: Byungwan Jun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfg alfg alfg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ian-spoonradio @alfg @unipro