fix: add negative lookbehind for comment in static import regex #838
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The static import regex is missing an exclusion for the case where the import statement is a comment. The esm shim will be added below the comment instead of the actual last import statement in this case. I didn't spend much time on the regex edit, so if there's a better implementation, please make any suggestions for improvements!
Changed the regex to ensure start of line
(?<=^(|\s|;)). Not sure if this is valid for all cases. For example, an invalid case where you have a space before the semicolon:An alternative is using a negative lookbehind for
//((?<!\/\/.*?)) which can be seen in the first commit:Additional context
I ran into this issue where it added the esm shim under the comment below instead. I didn't test thoroughly but it seems like the esm shim plugin runs before comments are removed in the build process.
Example:
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).