Bulk load CDK: log diagnostics when unflushed states at end of sync #68668
+33
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Helpful Resources
PR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
|
subodh1810
reviewed
Oct 28, 2025
| /** Log some information about why state messages cannot be flushed. */ | ||
| // implementation-wise, this is largely just mirroring getNextComplete(), | ||
| // except it logs things instead of actually doing anything. | ||
| fun logStateInfo() { |
There was a problem hiding this comment.
Can we log full state message as well?
subodh1810
reviewed
Oct 28, 2025
subodh1810
approved these changes
Oct 28, 2025
# Conflicts: # airbyte-cdk/bulk/changelog.md # airbyte-cdk/bulk/version.properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Auto-merge enabled.
This PR is set to merge automatically when all requirements are met.