Skip to content

Conversation

@ohadmata
Copy link

@ohadmata ohadmata commented Oct 27, 2025

What

#68660

How

Set None as default values for the optional fields in FieldMeta object

Review guide

types.py

User Impact

The user will be able to read streams with subform types

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


ohadmata seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link
Contributor

👋 Welcome to Airbyte!

Thank you for your contribution from ohadmata/airbyte! We're excited to have you in the Airbyte community.

Helpful Resources

PR Slash Commands

As needed or by request, Airbyte Maintainers can execute the following slash commands on your PR:

  • /format-fix - Fixes most formatting issues.
  • /bump-version - Bumps connector versions.
  • /run-connector-tests - Runs connector tests.
  • /run-cat-tests - Runs CAT tests.
  • /build-connector-images - Builds and publishes a pre-release docker image for the modified connector(s).

If you have any questions, feel free to ask in the PR comments or join our Slack community.

Tips for Working with CI

  1. Pre-Release Checks. Please pay attention to these, as they contain standard checks on the metadata.yaml file, docs requirements, etc. If you need help resolving a pre-release check, please ask a maintainer.
    • Note: If you are creating a new connector, please be sure to replace the default logo.svg file with a suitable icon.
  2. Connector CI Tests. Some failures here may be expected if your tests require credentials. Please review these results to ensure (1) unit tests are passing, if applicable, and (2) integration tests pass to the degree possible and expected.
  3. (Optional.) BYO Connector Credentials for tests in your fork. You can optionally set up your fork with BYO credentials for your connector. This can significantly speed up your review, ensuring your changes are fully tested before the maintainers begin their review.

📝 Edit this welcome message.

@ohadmata ohadmata changed the title Set None as default values for the FieldMeta object for cases of miss… [source-zoho-crm] Can't get source schema when "length" field is missing Oct 27, 2025
@DanyloGL
Copy link
Collaborator

@ohadmata thank you for your contribution! Could you please sign Contributor License Agreement before we review and test you PR?

@DanyloGL DanyloGL moved this from New PRs to Waiting Contributor in 🧑‍🏭 Community Pull Requests Oct 31, 2025
@ohadmata
Copy link
Author

ohadmata commented Nov 2, 2025

@DanyloGL Already signed it. There is no option to sign again.
I have no idea why the status of this stage is still pending... :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Waiting Contributor

Development

Successfully merging this pull request may close these issues.

4 participants