Skip to content

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented Oct 13, 2024

val.netloc is accessed on a namedtuple, which is much a bit faster than calling the property (even the cython version)

The bechmark only shows ~4% improvement so not worth of a changelog message

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 13, 2024

CodSpeed Performance Report

Merging #1252 will not alter performance

Comparing use_val_internal (e716fef) with master (91c4d92)

Summary

✅ 45 untouched benchmarks

@codecov
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.83%. Comparing base (91c4d92) to head (e716fef).
Report is 188 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1252   +/-   ##
=======================================
  Coverage   95.83%   95.83%           
=======================================
  Files          27       27           
  Lines        5167     5168    +1     
  Branches      314      314           
=======================================
+ Hits         4952     4953    +1     
  Misses        189      189           
  Partials       26       26           
Flag Coverage Δ
CI-GHA 95.82% <100.00%> (+<0.01%) ⬆️
MyPy 43.81% <100.00%> (+0.01%) ⬆️
OS-Linux 99.35% <100.00%> (+<0.01%) ⬆️
OS-Windows 99.41% <100.00%> (+<0.01%) ⬆️
OS-macOS 99.06% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 98.97% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 99.23% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 99.23% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 98.97% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 99.23% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 99.23% <100.00%> (+<0.01%) ⬆️
Py-3.8.10 98.92% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 99.18% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 98.92% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 99.18% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.11 99.24% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 99.24% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.17 99.26% <100.00%> (+<0.01%) ⬆️
VM-macos-latest 99.06% <100.00%> (+<0.01%) ⬆️
VM-ubuntu-latest 99.35% <100.00%> (+<0.01%) ⬆️
VM-windows-latest 99.41% <100.00%> (+<0.01%) ⬆️
pytest 99.35% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco
Copy link
Member Author

bdraco commented Oct 13, 2024

We have no benchmarks for is_default_port or equality

val.netloc is accessed on a namedtuple, which is much faster
@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Oct 13, 2024
@bdraco bdraco marked this pull request as ready for review October 13, 2024 16:05
@bdraco bdraco merged commit 5c56ba2 into master Oct 13, 2024
49 of 51 checks passed
@bdraco bdraco deleted the use_val_internal branch October 13, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:skip This PR does not need to include a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants