-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Ignore partitioned attributes in cookies if it is not supported by http.cookie #11529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore partitioned attributes in cookies if it is not supported by http.cookie #11529
Conversation
to prevent custom attributes from breaking cookiejar save and load
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11529 +/- ##
==========================================
+ Coverage 97.67% 98.68% +1.01%
==========================================
Files 127 127
Lines 43354 43371 +17
Branches 2325 2325
==========================================
+ Hits 42345 42800 +455
+ Misses 826 416 -410
+ Partials 183 155 -28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #11529 will not alter performanceComparing Summary
|
Backport to 3.13: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 9a2f146 on top of patchback/backports/3.13/9a2f146a12e3525b43e96723ef41584bf9cf784e/pr-11529 Backporting merged PR #11529 into master
🤖 @patchback |
…tp.cookie (aio-libs#11529) (cherry picked from commit 9a2f146)
What do these changes do?
Only set
partitioned
flag if it is supported by http.cookie (in python >= 3.14 or monkey-patched). Fix issue where saved cookiejars fail to be unpickled due to unsupported attribute. (At least clients without partitioned cookies supports can load cookiejars created by themselves.)Are there changes in behavior for the user?
Is it a substantial burden for the maintainers to support this?
Related issue number
Fixes #11523
Checklist
CONTRIBUTORS.txt
CHANGES/
folder