[PR #11234/a83597fa backport][3.12] Document exceptions raised by send_frame et al. #11262
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #11234 as merged into master (a83597f).
What do these changes do?
This PR updates the web reference docs of
aiohttp.web.WebSocketResponse.send_frameet al. with previously missing:raisedeclarations.Most notably,
send_frame,send_str,send_bytes, andsend_jsonall raiseaiohttp.ClientConnectionResetError, which was previously undocumented. Additionally, it was not documented thatsend_framemay raise aRuntimeErrorif the connection is not started yet.For reference, here are the relevant code snippets:
send_frameraisingRuntimeErrorif the connection is not started yet:aiohttp/aiohttp/web_ws.py
Lines 405 to 411 in 7c3afd2
send_frameet al. raisingaiohttp.ClientConnectionResetErrorif the connection is closing:aiohttp/aiohttp/_websocket/writer.py
Lines 71 to 72 in 7c3afd2
aiohttp/aiohttp/_websocket/writer.py
Lines 125 to 126 in 7c3afd2
Are there changes in behavior for the user?
No
Is it a substantial burden for the maintainers to support this?
pause
No
Related issue number
n/a
Checklist
CONTRIBUTORS.txtCHANGES/foldername it
<issue_or_pr_num>.<type>.rst(e.g.588.bugfix.rst)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature: A new behavior, public APIs. That sort of stuff..deprecation: A declaration of future API removals and breakingchanges in behavior.
.breaking: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc: Notable updates to the documentation structure or buildprocess.
.packaging: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.