Skip to content

Conversation

maldoinc
Copy link
Contributor

@maldoinc maldoinc commented Jun 22, 2025

What do these changes do?

Add Wireup to list of third-party libraries. Wireup is a modern dependency injection container with first-class support for AIOHTTP.

Are there changes in behavior for the user?

No

Is it a substantial burden for the maintainers to support this?

No

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jun 22, 2025
Copy link

codecov bot commented Jun 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.76%. Comparing base (7c3afd2) to head (f34599d).
⚠️ Report is 404 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11233      +/-   ##
==========================================
- Coverage   98.84%   98.76%   -0.09%     
==========================================
  Files         131      129       -2     
  Lines       43280    43377      +97     
  Branches     2328     2323       -5     
==========================================
+ Hits        42782    42840      +58     
- Misses        343      383      +40     
+ Partials      155      154       -1     
Flag Coverage Δ
CI-GHA 98.64% <ø> (-0.10%) ⬇️
OS-Linux 98.38% <ø> (-0.09%) ⬇️
OS-Windows 96.80% <ø> (-0.01%) ⬇️
OS-macOS 97.69% <ø> (-0.01%) ⬇️
Py-3.10.11 97.32% <ø> (-0.02%) ⬇️
Py-3.10.18 97.73% <ø> (-0.10%) ⬇️
Py-3.11.13 97.92% <ø> (-0.10%) ⬇️
Py-3.11.9 97.52% <ø> (-0.01%) ⬇️
Py-3.12.10 97.63% <ø> (+<0.01%) ⬆️
Py-3.12.11 98.02% <ø> (-0.09%) ⬇️
Py-3.13.3 98.28% <ø> (-0.10%) ⬇️
Py-3.9.13 97.22% <ø> (-0.02%) ⬇️
Py-3.9.23 97.61% <ø> (-0.09%) ⬇️
Py-pypy7.3.16 89.33% <ø> (-2.77%) ⬇️
VM-macos 97.69% <ø> (-0.01%) ⬇️
VM-ubuntu 98.38% <ø> (-0.09%) ⬇️
VM-windows 96.80% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jun 22, 2025

CodSpeed Performance Report

Merging #11233 will not alter performance

Comparing maldoinc:patch-1 (f34599d) with master (202b314)

Summary

✅ 59 untouched benchmarks

Co-authored-by: Cycloctane <[email protected]>
@Dreamsorcerer Dreamsorcerer added the backport-3.13 Trigger automatic backporting to the 3.13 release branch by Patchback robot label Jul 14, 2025
@Dreamsorcerer Dreamsorcerer merged commit cb2860a into aio-libs:master Jul 14, 2025
40 checks passed
Copy link
Contributor

patchback bot commented Jul 14, 2025

Backport to 3.13: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.13/cb2860ab9a62cbc9d2785195278496f4d26ec9ca/pr-11233

Backported as #11310

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 14, 2025
Dreamsorcerer pushed a commit that referenced this pull request Jul 14, 2025
…es (#11310)

**This is a backport of PR #11233 as merged into master
(cb2860a).**

Co-authored-by: Aldo Mateli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-3.13 Trigger automatic backporting to the 3.13 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants