Skip to content

Conversation

@alam0rt
Copy link
Contributor

@alam0rt alam0rt commented Jul 11, 2022

In a multi-tenant cluster, rarely do users have permissions to view all API resources. This makes it so any resource that is forbidden to the user will be skipped.

Fixes #14
Fixes #60

@ghost ghost mentioned this pull request Feb 15, 2023
@ahmetb
Copy link
Owner

ahmetb commented Feb 15, 2023

I think this is agreeable, there's just a little bug that we need to assign to errResult only if it's not a Forbidden error. I'll push that commit and merge.

@yutkin
Copy link

yutkin commented Jan 12, 2024

Any updates on that?

@rkulow
Copy link

rkulow commented May 13, 2024

+1, would be nice to see this merged.

@ghost
Copy link

ghost commented Jul 1, 2024

+1 waiting for it

Copy link
Owner

@ahmetb ahmetb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Only one small comment.

uses: actions/setup-go@v1
with:
go-version: 1.18
go-version: 1.20
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to type ' or " around this otherwise it becomes 1.2 float :) at this point let's do 1.22

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omg i made this error myself it turns out 🤦

@initor
Copy link

initor commented Aug 5, 2024

+1, would be nice to see this merged.

@alam0rt
Copy link
Contributor Author

alam0rt commented Oct 22, 2024

sorry for the delay - missed this.

hows this look?

@dacofr
Copy link

dacofr commented Nov 20, 2024

+1
Hello, When do you think this fix can be merged ?
Thanks

@ahmetb
Copy link
Owner

ahmetb commented Nov 23, 2024

it seems --rm-dist flag got removed from goreleaser, in favor of --clean.

@ahmetb ahmetb merged commit 8e5b6d7 into ahmetb:master Nov 23, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fails if privileges are limited Allow skipping resources which are not accessible with current permission

6 participants