[C++] Add definition for __PROJECT_SOURCE_DIR__ to aeron_client's public interface #596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will further allow us to inherit other libraries and compile definitions that the aeron_client's public interface requires.
denizevrenci
force-pushed
the
more_cmake
branch
from
b9cce93 to
795fe35
Compare
…lic interface. This is required in case there is an upper level directory that includes Aeron. In that case the added definitions do not reach the source files that may include Aeron headers and __PROJECT_SOURCE_DIR__ will be undefined to them.
denizevrenci
changed the title
denizevrenci
force-pushed
the
more_cmake
branch
from
795fe35 to
435e276
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required in case there is an upper level directory that includes
Aeron. In that case the added definitions do not reach the source files
that may include Aeron headers and PROJECT_SOURCE_DIR will be
undefined to them.