[Java/C] Report unique loss #1796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyazelenko
added a commit
that referenced
this pull request
May 9, 2025
* [Java] Report lost bytes only once, i.e. do not overcount loss when retry interval fires. * [Java] Assert that NAK fields are updated every time the method is called. * [C] Only report unique bytes lost. * [C++] Cleanup test resources. * [C++] Fix memory leak. * [C] Naming.
vyazelenko
added a commit
that referenced
this pull request
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid recording the same or overlapping loss into the loss report, i.e. only record unique loss events but not the resends of the same NAKs.
NB: With this change the number of loss observations will no longer match the number of NAKs sent.