updated wording of UTF-8 file load error. #7932
Conversation
src/nls/root/strings.js
Outdated
There was a problem hiding this comment.
We should somehow make clear the opened file isn't UTF-8.
There was a problem hiding this comment.
How's this?
"The file is not UTF-8 encoded text. Brackets currently only supports UTF-8 encoded text files."
There was a problem hiding this comment.
That's easy, but ok with me.
h1w4y
changed the title
|
oops! Thanks. I better start reading the code ;) |
bchintx
changed the title
|
@njx I think this is a good idea, but can you give this string change a quick review? |
|
I think we wanted to just replace the second sentence instead of appending to it. It feels a bit redundant with both. (I guess that's what @HighwayChile had originally.) @SAplayer - it seems to me like saying "The file foo.js could not be opened. Brackets currently only supports UTF-8 encoded text files." makes it pretty clear that the reason the file couldn't be opened is that it's not a UTF-8 text file. Do you think the extra sentence is necessary? |
|
@njx Ah yes, I didn't think about the first sentence ("The file foo.js could not be opened."). I'm ok with it either way. |
|
Cool. @HighwayChile, sorry for the churn - if you could change it back to just the |
|
@njx I'll be happy to make that change. |
|
Thanks. Merging. |
updated wording of UTF-8 file load error.
5 participants
addresses Issue #7850
When opening a non UTF-8 file, the second and third sentences of the error message will now read: "The file is not UTF-8 encoded text. Brackets currently only supports UTF-8 encoded text files."