This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Clicking an Image file in the project tree calls FileOpen command twice #6513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge between the case where it needs to open the file before redrawing the tree or just go ahead and redraw because the custom viewer for the file entry is already open.
|
I can review this. @couzteau this doesn't need to land in Sprint 36, does it? |
ghost
assigned
|
@peterflynn - right no need to rush this into 36. The bug is lo prio and was not on nominated for S36. |
|
@peterflynn This has been open for a couple months now. Looks like you are overloaded. Do you still want to review it or should I try to find someone else? |
|
This is obsoleted by the project manager revamp in pr #9015. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6001
Enable project manager to differentiate on documentSelectionFocusChange between
a) the case where it needs to open the file before redrawing the tree or
b) go ahead and redraw because the custom viewer for the file entry is already open.
Essentially the fix does the same as the work around in DCHs did, that is check if we already display the file before calling the FILE_OPEN cmd.