This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Change not.toBeNull() to toBeTruthy() in unit tests #5492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Edited the subject line of the pull request to make it more clear what it was about (pull requests should have semantic titles rather than just the name of the bug they're addressing). Thanks. |
ghost
assigned
|
Looks good! Thanks for doing this, @gmeluski |
dangoor
added a commit
that referenced
this pull request
Oct 18, 2013
Change not.toBeNull() to toBeTruthy() in unit tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for #5479
Please let me know if I missed anything, this is my first one!