This repository was archived by the owner on Sep 2, 2021. It is now read-only.
Support more common key names in native menus #495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@rlim Why can't the new keys be defined using same pattern as existing keys? For example:
const ExtensionString pageUp = (ExtensionString() += NSPageUpFunctionKey);Seems simpler and more consistent.
There was a problem hiding this comment.
@redmunds Because they're unichar and we need to convert them to UTF8. Otherwise, you will see a different character show up in the menu. e.g. PageUp shows up as a comma
|
@rlim Done with code review. Works great. Just 1 comment. |
|
Looks good. Merging. |
redmunds
added a commit
that referenced
this pull request
Jan 16, 2015
Support more common key names in native menus
redmunds
added a commit
that referenced
this pull request
Dec 8, 2015
Support more common key names in native menus
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue adobe/brackets#10249.