Skip to content

[ISSUE-4] Successful request validation quits access phase #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2015
Merged

[ISSUE-4] Successful request validation quits access phase #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
154effa
[ISSUE-4] Successful request validation quits access phase
alexpopero Nov 4, 2015
1e3f3ff
[ADDENDUM][ISSUE-4] Include the OPTIONS method validation
alexpopero Nov 5, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lua/api-gateway/validation/factory.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ end
-- It calls an internal /validate-request path which can provide any custom implementation for request validation
local function _validateRequest()
if (ngx.var.request_method == 'OPTIONS') then
return ngx.exit(ngx.OK);
return ngx.OK;
end

local res = ngx.location.capture("/validate-request", { share_all_vars = true });
Expand All @@ -64,7 +64,7 @@ local function _validateRequest()
end

if res.status == ngx.HTTP_OK then
return ngx.exit(ngx.OK);
return ngx.OK;
end

if res.status == ngx.HTTP_FORBIDDEN or res.status == ngx.HTTP_UNAUTHORIZED or res.status == ngx.HTTP_BAD_REQUEST or tonumber(res.status) > 599 then
Expand Down