use forced content type for pyportal discord #1980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue that this resolves was raised here: adafruit/Adafruit_CircuitPython_PortalBase#57
This project fetches an SVG file and then parses it as text.
At some point the PyPortal library got improved features for handling more content types and it started relying on content_type returned by the server.
In the case of this project it broke because the server is using image/svg type, but we want to ignore image and parse it as text.
This uses the fix introduced with: adafruit/Adafruit_CircuitPython_PyPortal#120
I tested this fix successfully on a PyPortal with 7.1.0