Fix image function when display rotated 90 or 270 degrees #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
requested review from
ladyada and
makermelissa
and removed request for
ladyada
Contributor
|
Discussion in #help-with-circuitpython 2020-09-07 starting 3:19pm ET. |
Author
|
Note: my development and testing was on a rpi with blinka and some 128x64 SSD1306 OLED displays. |
makermelissa
approved these changes
Sep 10, 2020
Collaborator
makermelissa
left a comment
makermelissa
left a comment
There was a problem hiding this comment.
This looks good to me.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Sep 11, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90640 to 1.2.0 from 1.1.5: > Merge pull request adafruit/Adafruit_CircuitPython_MLX90640#21 from adafruit/fix-pylint > Merge pull request adafruit/Adafruit_CircuitPython_MLX90640#18 from fgervais/broken-pixels Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 3.4.0 from 3.3.1: > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#83 from cjsieh/scard_vs_sdcardio Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 7.3.0 from 7.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_BLE#103 from dhalbert/hci Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_BerryMed_Pulse_Oximeter to 2.0.2 from 2.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_BerryMed_Pulse_Oximeter#4 from dhalbert/up-to-date-data Updating https://github.com/adafruit/Adafruit_CircuitPython_framebuf to 1.4.1 from 1.3.4: > Merge pull request adafruit/Adafruit_CircuitPython_framebuf#35 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_framebuf#34 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_framebuf#33 from jsharper/fix/jsharper/image-rotate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is the best way or place to fix this. Feel free to close/reject if there's a better way.
Without this change, I was unable to properly use the image function to draw a PIL image when a non-square display was set to 90 or 270 degree rotation. This change allows the passed image to match the effective resolution of the rotated display, allowing the entire image to be displayed (rotated appropriately).