Add familiar Mac and Windows names for GUI and ALT keys. #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattni
approved these changes
Nov 1, 2018
Contributor
kattni
left a comment
kattni
left a comment
There was a problem hiding this comment.
Looks good, thanks for adding this!
Collaborator
Author
|
Tested on a Mac and on Linux (which uses the WINDOWS key). |
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 2, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 2.0.4 from 2.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#42 from dhalbert/frozen-order Updating https://github.com/adafruit/Adafruit_CircuitPython_Crickit to 2.1.2 from 2.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_Crickit#10 from dhalbert/frozen-order > ignore the board module imports in .pylintrc Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3DH to 4.3.3 from 4.3.2: > Update spinner_advanced.py > Merge pull request adafruit/Adafruit_CircuitPython_LIS3DH#47 from adafruit/ladyada-patch-2 Updating https://github.com/adafruit/Adafruit_CircuitPython_Thermistor to 3.2.1 from 3.2.0: > ignore the board module imports in .pylintrc Updating https://github.com/adafruit/Adafruit_CircuitPython_BusDevice to 2.2.6 from 2.2.5: > ignore the board module imports in .pylintrc Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 3.3.0 from 3.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_HID#27 from dhalbert/gui-alt-key-aliases Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 1.3.2 from 1.3.1: > ignore the board module imports in .pylintrc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Keycode names that correspond to Mac and Windows keyboard labels, for more obvious use without having to refer to the documentation.
Keycode.WINDOWSandKeycode.COMMANDas aliases forKeycode.GUI.Keycode.OPTIONas alias forKeycode.ALT.I want to get this in before I freeze the latest lib versions for CPy 3.1.0.