Fixed infinite loop when socket readline fails #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
looks good! we prefer a time-based timeout with |
In certain cases, the socket may not receive a full response (or any response), causing the while loop in readline to go on forever. After failing to receive any data, this fix will raise an exception and fail out.
cpforbes
reviewed
May 10, 2019
Co-Authored-By: Craig <[email protected]>
ladyada
approved these changes
May 25, 2019
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
May 28, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_BD3491FS to 1.0.3 from 1.0.1: > once more with gusto Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 1.3.8 from 1.3.7: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#42 from ZachNo/socket_hang_fix > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#44 from cpforbes/socket_timeout > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#40 from cpforbes/wifi_fix Updating https://github.com/adafruit/Adafruit_CircuitPython_INA260 to 1.1.2 from 1.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_INA260#5 from siddacious/blinka_fix Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_BD3491FS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain cases, the socket may not receive a full response (or any
response), causing the while loop in readline to go on forever. After
failing to receive any data, this fix will raise an exception and fail
out.
Mitigates #11