Correct bug of modifying self rather than self.local_group when text … #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 15, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.9.4 from 2.9.3: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#98 from kmatch98/blank_text Updating https://github.com/adafruit/Adafruit_CircuitPython_MagTag to 1.0.2 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#8 from ladyada/main > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#7 from makermelissa/main > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#6 from ladyada/main > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#3 from makermelissa/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.8.1 from 1.8.0: > Merge pull request adafruit/Adafruit_CircuitPython_Requests#53 from jepler/circuitpython-compat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…is blank
This was a bug that was introduced when the separate self and self.local_group was added to handle modifying the scaling on the fly.
The bug was when the text was "" and it actually was modifying the self group rather than the self.local_group. Pull request is incoming.
Resolves issue #97