Return NaN only if sampling is disabled #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should close #114 |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the behavior for sensor reading functions so that NAN is returned when sampling is disabled rather than detecting invalid ADC values, and adjusts the associated documentation.
- Update the sampling condition checks in readTemperature, readPressure, and readHumidity to return NAN if sampling is off.
- Modify the header comments to correctly describe humidity oversampling.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Adafruit_BME280.h | Updated the comment for osrs_h to reflect humidity oversampling correctly. |
| Adafruit_BME280.cpp | Added early sampling mode checks in sensor reading functions to return NAN. |
Files not reviewed (1)
- library.properties: Language not supported
tyeth
changed the title
|
@ladyada ready for review |
ladyada
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the functionality for pressure/temperature/humidity from returning NaN at key values (fixed values returned when sampling rate is None/Skip), to returning NaN if sampling is off.
Minor docstring changes too.
Tested on MetroS3 w/BME280, using simple test and advanced test with humidty test scenario (shows pressure and altitude return nan as pressure sampling is off).
Not verified that exactly 80% relative humidity can be returned (but logically ok).