-
-
Notifications
You must be signed in to change notification settings - Fork 110
fix(url): handle tab/newline-only inputs in set_port #961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
My reading of the spec is as follows:
So I think @watilde is correct. Anything non-empty that does not parse to a 16-bit integer should leave the port unchanged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is a genuine bug worth fixing.
I'll wait for @anonrig to react before we merge. |
It seems there are linting errors |
Working on fixing the lint errors. I’ll push the changes shortly. |
b332e07
to
47b7cef
Compare
I ran clang-format to fix the lint errors, amended the previous commit, and force-pushed to keep the commit history clean. |
Thank you for your contribution |
This change updates set_port so that when the input consists only of tab (\t), newline (\n), or carriage return characters, the port is left unchanged. Also adds these cases to ada_extra_setters_tests.json while waiting for their inclusion in WPT.
Refs: web-platform-tests/wpt#53420