Skip to content

feat: Optimize to_string #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2025
Merged

feat: Optimize to_string #959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/ada/encoding_type.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ enum class encoding_type {
/**
* Convert a encoding_type to string.
*/
ada_warn_unused std::string to_string(encoding_type type);
ada_warn_unused std::string_view to_string(encoding_type type);

} // namespace ada

Expand Down
2 changes: 1 addition & 1 deletion src/implementation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ bool can_parse(std::string_view input, const std::string_view* base_input) {
return result.is_valid;
}

ada_warn_unused std::string to_string(ada::encoding_type type) {
ada_warn_unused std::string_view to_string(ada::encoding_type type) {
switch (type) {
case ada::encoding_type::UTF8:
return "UTF-8";
Expand Down
Loading