Skip to content

Fixing #935 #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 9, 2025
Merged

Fixing #935 #937

merged 4 commits into from
Apr 9, 2025

Conversation

the-moisrex
Copy link
Contributor

This fixes #935

The code for fast path, assumed only 1 dot exists.

@the-moisrex the-moisrex mentioned this pull request Apr 9, 2025
Closed
@anonrig anonrig requested a review from lemire April 9, 2025 10:52
lemire
lemire approved these changes Apr 9, 2025
View reviewed changes
Copy link
Member

@lemire lemire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like great work.

@anonrig anonrig merged commit 374eeaf into ada-url:main Apr 9, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemire lemire lemire approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Path with a dot folder does not return the normalized path
3 participants
@the-moisrex @lemire @anonrig