Add compatibility for Ruby 3.0 #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Fivell is it possible to get a review on this? |
|
Hi @clinejj I was out of Ruby-world for while. If nobody look at this PR for next few weeks, I'll try to get to it (it looks safe). PS: Thank you for also updating the Travis CI matrix. |
|
No worries, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses two issues where method calls needed to be updated due to changes in Ruby 3.0 argument passing. I also updated the CI configuration to add Ruby 3 and newer bugfix builds of Ruby/Rails, but happy to revert those changes if needed. I also added sassc-rails to the Gemfile, as development/testing doesn't work out of the box without it.
Fixes #189