Skip to content

Conversation

cshaver
Copy link
Collaborator

@cshaver cshaver commented May 6, 2020

This is a quick first pass at starting to use the new Layout component added in graphql#1145 🎉

Screen Shot 2020-05-05 at 10 38 43 p m

@acao
Copy link
Owner

acao commented May 6, 2020

@walaura big mood

@harshithpabbati
Copy link

@acao I added tabs to editors and here is the draft PR

Screenshot 2020-05-06 at 9 31 22 PM

But still, I have a small problem. Editor in Query tab is having default height of 5px. I am not able to figure out why it is happening.

@harshithpabbati
Copy link

@acao I added tabs to editors and here is the draft PR

Screenshot 2020-05-06 at 9 31 22 PM

But still, I have a small problem. Editor in Query tab is having default height of 5px. I am not able to figure out why it is happening.

Or should I send a new PR over here?

@acao
Copy link
Owner

acao commented May 6, 2020

@harshithpabbati I think I will merge this PR as is, and you can open your PR against the updated feat/use-context-hooks, sound good?

@harshithpabbati
Copy link

yeah okay, cool!

@acao acao marked this pull request as ready for review May 6, 2020 16:59
@acao acao changed the title [WIP] feat: graphiql redesign using new layout component feat: first pass graphiql redesign using new layout component May 6, 2020
@acao acao merged commit 36b8c7e into acao:feat/use-context-hooks May 6, 2020
@acao
Copy link
Owner

acao commented May 6, 2020

@harshithpabbati now, if you open a PR against acao:feat/use-context-hooks like she did, you'll be good to go!

@harshithpabbati
Copy link

@harshithpabbati now, if you open a PR against acao:feat/use-context-hooks like she did, you'll be good to go!

Yeah, doing it just a min

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants