Maite modules batch 3 #1302
Open
Maite modules batch 3 #1302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the artifact to use context. Removed unused code, deprecated timezone offset handling
Replaces direct plist parsing and deserialization with the get_plist_file_content. Removes unused imports
JamesHabben
reviewed
Oct 9, 2025
JamesHabben
reviewed
Oct 9, 2025
|
|
||
| data_list.append( | ||
| (fire_date, | ||
| None, # alarm time |
There was a problem hiding this comment.
great catch on this data misalignment. i am not super familiar with this artifact, is the 'MTSleepAlarm' condition never having a time? did you find any examples to validate in test data?
There was a problem hiding this comment.
I just put None in there to fix the alignment. I thought about getting the hour and minute to build the time string, but I have no idea what the internal structure for that artifact looks like and didn't want to assume those fields exist. I couldn't find any test data.
Added checks to ensure that parsed plist files are valid dictionaries before accessing their contents.
Added checks to ensure plist files are valid and dictionaries before processing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix in appleAlarms.py:
Fixed data alignment issue by adding None placeholder in alarm time column for sleep alarms when no alarm time was present.
Standardization Across Multiple Modules:
Updated function signatures: Changed to use context parameter
plist processing in appItunesmeta.py: Replaced direct plist library calls with get_plist_file_content() function