Rename dependency attribute is_resolved to is_pinned #638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alok1304
force-pushed
the
rename_dependency_is_resolved
branch
from
ff2a84b to
8568d5e
Compare
|
Hey @alok1304 , sorry for the delayed response Can you also rename resolved to pinned in labels and UI fields too (eg. headerName in Thanks |
Renaming the dependency attribute is_resolved to is_pinned. Output changes when we use is_resolved. Reference: aboutcode-org#634 Signed-off-by: Alok Kumar <[email protected]>
Signed-off-by: Alok Kumar <[email protected]>
alok1304
force-pushed
the
rename_dependency_is_resolved
branch
from
a06679a to
e967f9e
Compare
|
Hii @OmkarPh , Also I changed |
|
LGTM, thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming the dependency attribute is_resolved to is_pinned. Output changes when we use is_resolved.
Reference: #634
Tasks
contribution guidelines
your PR Run
tests
locally to check for errors.
applicable
Signed-off-by: Alok Kumar [email protected]