Skip to content

Conversation

AlexAzartsev
Copy link
Contributor

No description provided.

@aarondfrancis
Copy link
Owner

@AlexAzartsev thanks for doing this! I'm curious why you bumped the minimum version of PHP 8 to PHP 8.0.2. Was that on purpose? I rolled it back for now, but I'm happy to re-apply it if there's a reason!

@aarondfrancis aarondfrancis merged commit cee9c55 into aarondfrancis:main Feb 13, 2022
@AlexAzartsev
Copy link
Contributor Author

@aarondfrancis, thx for merge my changes, laravel 9 has minimum required version of php 8.0.2
you can find this info in official docs:
https://laravel.com/docs/9.x/upgrade#updating-dependencies
I don't know why exactly they decided to use this version as minimum required, but I just followed their guides :)
I'm pretty sure you can keep 8.0 as minimum in your package.

@aarondfrancis
Copy link
Owner

Ha well that's a pretty good reason! Thanks for the link. I'll probably leave it because Laravel 8 can presumably run on 8.0.0? In reality either way probably won't have any effect on anyone!

Thanks again 😄

@AlexAzartsev
Copy link
Contributor Author

Yep, it is true, 8.0 will be better for previous versions.
Thx you your package :)

@AlexAzartsev
Copy link
Contributor Author

@aarondfrancis please make a new release with these changes, so I can switch back to use your package in composer.json instead of my fork, thx :)

@benholmen
Copy link

@aarondfrancis I'll give you a Tightenbuck if you tag this today 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants