Skip to content

Conversation

@vraja-pro
Copy link
Contributor

@vraja-pro vraja-pro commented Oct 23, 2025

Context

  • We want to hide the llm txt opt in notification for the FTC. In this PR we add a system for opt ins.

Summary

This PR can be summarized in the following changelog entry:

  • Removes the llm txt opt in notification from First Time Configuration tab.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Make sure the llm txt feature is disabled.
  • In the database wp_usermeta, search for wpseo_seen_llm_txt_opt_in_notification and remove it.
  • Go to Yoast SEO -> General
  • Check you see the llm txt opt in notification:
Screenshot 2025-10-23 at 12 09 26
  • Navigate to the First time configuration tab and check you don't get the notification again.
  • In the database wp_usermeta, search for wpseo_seen_llm_txt_opt_in_notification and remove it.
  • While on the FTC tab, reload the page and check you don't see the llm txt opt in.
  • Navigate to other tabs and check you now get the opt in.
  • Reload the page and check you do not see opt in anymore.
  • In the database wp_usermeta, search for wpseo_seen_llm_txt_opt_in_notification and remove it.
  • Go to Yoast SEO -> features
  • Enable the llm txt feature
  • Go to Yoast SEO -> General
  • Check you don't see the opt in.
  • Disable the llm txt feature and check you see the llm txt opt in in general page.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes Don't show toast notifications on FTC

@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Oct 23, 2025
@vraja-pro vraja-pro force-pushed the 809-dont-show-toast-notifications-on-ftc branch from 16c25ae to 568aeeb Compare October 23, 2025 09:35
Fix tests
@vraja-pro vraja-pro force-pushed the 809-dont-show-toast-notifications-on-ftc branch from 568aeeb to 34ddcca Compare October 23, 2025 09:36
@coveralls
Copy link

coveralls commented Oct 23, 2025

Pull Request Test Coverage Report for Build 1b9c31ce77767849a63850005ed3bedaa6d28813

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 58 of 94 (61.7%) changed or added relevant lines in 5 files are covered.
  • 176 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.2%) to 53.406%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/general/components/llm-txt-opt-in-container.js 1 7 14.29%
packages/js/src/general/components/llm-txt-opt-in-notification.js 2 14 14.29%
packages/js/src/general/store/opt-in.js 0 18 0.0%
Files with Coverage Reduction New Missed Lines %
packages/js/src/components/modals/PremiumSEOAnalysisModal.js 1 0.0%
packages/js/src/redux/reducers/preferences.js 2 0.0%
src/editors/framework/site/post-site-information.php 2 95.65%
packages/js/src/general/components/llm-txt-opt-in-notification.js 2 10.53%
packages/js/src/dynamic-blocks.js 2 0.0%
packages/js/src/components/modals/UpsellModal.js 2 6.25%
admin/tracking/class-tracking-settings-data.php 7 0.0%
packages/js/src/ai-generator/components/modal-content.js 43 2.15%
admin/metabox/class-metabox.php 49 19.44%
packages/js/src/ai-generator/components/app.js 66 2.16%
Totals Coverage Status
Change from base Build 0b2a096bf20877dca314ef48e5093426b4965cd4: 0.2%
Covered Lines: 32184
Relevant Lines: 60488

💛 - Coveralls

@vraja-pro vraja-pro force-pushed the 809-dont-show-toast-notifications-on-ftc branch from e296707 to 2f8db84 Compare October 23, 2025 12:19
@vraja-pro vraja-pro force-pushed the 809-dont-show-toast-notifications-on-ftc branch from 2f8db84 to 47636e5 Compare October 23, 2025 12:55
@pls78 pls78 added this to the 26.4 milestone Oct 30, 2025
Copy link
Member

@pls78 pls78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Acc: 🔴
I feel this behavior is not what we want:

  • I'm on the FTC tab
  • I delete the option from the db
  • I refresh the FTC tab -> I don't see the notification ✅
  • I switch to one of the other two General tabs -> I see the notification ✅
  • I refresh the tab -> I still get the notification ❌
  • If I switch to the FTC tab and Go back to one of the other two tabs, the notification is not shown ✅

mounting will update the db.
Unmounting and dismissing will hide the opt in.
Copy link
Member

@pls78 pls78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR && Acc: ✅

@pls78 pls78 merged commit c6d2630 into trunk Oct 31, 2025
37 checks passed
@pls78 pls78 deleted the 809-dont-show-toast-notifications-on-ftc branch October 31, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants