-
Notifications
You must be signed in to change notification settings - Fork 943
Feature/re organize ai code #22615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
pls78
wants to merge
66
commits into
trunk
Choose a base branch
from
feature/re-organize-ai-code
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feature/re organize ai code #22615
+5,648
−750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-related modules
This is done so that our DI container knows which endpoints to gather in each integration through the endpoints repo
This is done to ensure backward compatibility with older versions of Premium which will still reference these classes
947a051 to
b253898
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog: non-user-facing
Needs to be included in the 'Non-userfacing' category in the changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
_deprecated_functionaccording to the release this PR will be part of.Summary
This PR can be summarized in the following changelog entry:
aiparent directory and consequently losing theAI_namespace/class prefixRelevant technical choices:
AI_prefix and are now under anaiparent directory.Endpoint_ListandEndpoints_Repositoryclasses have been moved tosrc/routes/endpointdirectory, so that they can be re-used throughout the codebase and not being re-declared each time.Consent_Endpoint_Interface,Free_Sparks_Endpoint_Interface,Generator_Endpoint_Interfacehave been introduced to let our DI container know which endpoints need to be gathered by the respective repository. As a result, they are attached to the respective integration window object in theendpointproperty (exception made for the Free Sparks one, which is bundled in thewpseoAiGeneratorwindow object.Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Relevant test scenarios
Test instructions for QA when the code is in the RC
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel.Fixes Make deprecated AI-related classes usable by Premium