Skip to content

Minor fixes, and some documentation #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 19, 2020
Merged

Minor fixes, and some documentation #2

merged 2 commits into from
Aug 19, 2020

Conversation

jkueh
Copy link

@jkueh jkueh commented Aug 19, 2020

This PR adds the following:

  • Documentation xero_app.rb
  • Some minor frontend fixes to make objects a bit more readable
  • A minor performance enhancement to avoid repeat initialisation of the Xero API client

Jordan Kueh added 2 commits August 19, 2020 17:43
Some frontend fixes - Using pp's pretty_inspect combined with <pre> t…
84e852c 
…ags to make the objects a bit more readable
Adding documentation, and making the xero_client a class variable to …
4455338 
…prevent repeat initialization of the API client.
@SerKnight
Copy link
Contributor

SerKnight commented Aug 19, 2020 •
edited
Loading

Hey @jkueh this is awesome! Thanks for the additions - Love all the comments. Big improvements.

  • Good catch with the performance improvement. Though one thing I will change is the use of global instance variable. @@ Generally frowned on in ruby code. I will replace with memoization ||=

@SerKnight SerKnight merged commit 83d4d8f into XeroAPI:master Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jkueh @SerKnight