Skip to content

Conversation

a-kore
Copy link
Collaborator

@a-kore a-kore commented Mar 15, 2024

Fix

Short Description

  • Fix logging for a single metric.

Tests Added

No tests added.

@amrit110 amrit110 requested a review from rjavadi March 15, 2024 16:23
@amrit110 amrit110 added the bug Something isn't working label Mar 15, 2024
@amrit110
Copy link
Member

@rjavadi, should hopefully fix the issue you highlighted in #582

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.48%. Comparing base (dff88de) to head (dfcfb8c).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #585   +/-   ##
=======================================
  Coverage   74.48%   74.48%           
=======================================
  Files         128      128           
  Lines       11361    11361           
=======================================
  Hits         8462     8462           
  Misses       2899     2899           
Files Coverage Δ
cyclops/report/report.py 72.68% <100.00%> (ø)

Impacted file tree graph

@rjavadi
Copy link
Collaborator

rjavadi commented Mar 15, 2024

Thank you @amrit110
LGTM😊. Some checks are still in progress.

@amrit110 amrit110 merged commit 31a1480 into main Mar 15, 2024
@amrit110 amrit110 deleted the fix_report_single_metric branch March 15, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants