Skip to content

Conversation

sasodoma
Copy link
Contributor

Added an additional theme which has the window background color as well as the primary color set to black. The theme is called AMOLED since the main incentive to have such a theme is energy saving on different OLED screens which emit no light when set to black.

This closes #483

I understand that this is probably not yet suitable for a merge so I'd like to ask what else needs to be done.

Tested on my Google Pixel 8 Pro running Android 16

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a new AMOLED theme with black backgrounds to save energy on OLED screens. The implementation adds theme styles, string resources, and configuration options to support the new theme alongside existing dark, light, and system themes.

  • Adds AMOLED theme styles with black window background and primary color
  • Updates theme selection arrays to include the new AMOLED option
  • Extends ThemeStyle enum to support AMOLED theme configuration

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
app/src/main/res/values/styles.xml Defines ThemeAmoled and ThemeAmoledNoActionBar styles with black backgrounds
app/src/main/res/values/strings.xml Adds theme_amoled string resource for UI display
app/src/main/res/values/arrays.xml Updates theme arrays to include AMOLED option
app/src/main/kotlin/com/vrem/wifianalyzer/settings/ThemeStyle.kt Adds AMOLED enum entry with corresponding style references
Comments suppressed due to low confidence (1)

@VREMSoftwareDevelopment
Copy link
Owner

When you get a chance, could you take care of the broken and missing unit tests?

Thanks so much for your contribution!

@sasodoma
Copy link
Contributor Author

Regarding the tests, I have to admit I don't have any experience with unit tests in Android but I will do a bit of research and get familiar. It will also be helpful for me, since I would like to implement a more major feature in the future (adding nicknames to easily tell BSSIDs apart). Feel free to leave this open if you would like to wait until I implement the tests.

@sasodoma
Copy link
Contributor Author

@VREMSoftwareDevelopment I noticed that everytime I build the version_build value in app/build.properties gets incremented. Should I push this change to the repo or leave it out?

@VREMSoftwareDevelopment
Copy link
Owner

@VREMSoftwareDevelopment I noticed that everytime I build the version_build value in app/build.properties gets incremented. Should I push this change to the repo or leave it out?

It is okay to merge

@sasodoma
Copy link
Contributor Author

I have added tests for the black theme to the ThemeStyleTest and I also extended the SettingsTest to be a bit more comprehensive. I hope this fits what you had in mind.

Copy link

codecov bot commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.62%. Comparing base (7f0dbf2) to head (ce9cabf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #549   +/-   ##
=========================================
  Coverage     96.62%   96.62%           
  Complexity      891      891           
=========================================
  Files           121      121           
  Lines          2580     2581    +1     
  Branches        202      202           
=========================================
+ Hits           2493     2494    +1     
  Misses           29       29           
  Partials         58       58           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@VREMSoftwareDevelopment VREMSoftwareDevelopment changed the title Implement AMOLED theme with black background Implement Black theme with black background Jul 21, 2025
@VREMSoftwareDevelopment VREMSoftwareDevelopment merged commit c060e9c into VREMSoftwareDevelopment:main Jul 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature request] Solid black (optional) for background

2 participants