Skip to content

Create ESM EE bundle #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Create ESM EE bundle #105

wants to merge 3 commits into from

Conversation

kylebarron
Copy link
Contributor

@kylebarron kylebarron commented Feb 12, 2021 •
edited
Loading

This adds two new ESM-formatted output bundles with only the EE dependency: dist/ee.mjs and dist/ee.min.mjs. I can test this correctly on localhost:
image

@kylebarron kylebarron requested a review from ibgreen February 12, 2021 17:02
ibgreen
ibgreen approved these changes Feb 12, 2021
View reviewed changes
Copy link
Contributor

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds two new ESM-formatted output bundles: dist.esm.js and dist.esm.min.js.

I think these should be called .mjs, but I haven't yet used such bundles.

@kylebarron kylebarron changed the title Add ESM output bundle Create ESM EE bundle Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ibgreen ibgreen ibgreen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kylebarron @ibgreen