Skip to content

Conversation

@Reqwey
Copy link
Collaborator

@Reqwey Reqwey commented Oct 25, 2025

Checklist

  • Changes have been tested locally and work as expected.
  • All tests in workflows pass successfully.
  • Documentation has been updated if necessary.
  • Code formatting and commit messages align with the project's conventions.
  • Comments have been added for any complex logic or functionality if possible.

This PR is a ..

  • 🆕 New feature
  • 🐞 Bug fix
  • 🛠 Refactoring
  • ⚡️ Performance improvement
  • 🌐 Internationalization
  • 📄 Documentation improvement
  • 🎨 Code style optimization
  • ❓ Other (Please specify below)

Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • e.g. close #xxxx, fix #xxxx

Description

  • Please insert your description here and provide info about the "what" this PR is solving.

Additional Context

  • Add any other relevant information or screenshots here.

@Reqwey Reqwey requested review from UNIkeEN and Copilot October 25, 2025 05:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the user experience by making instance and player cards fully clickable, even when they contain interactive menu buttons. Previously, cards with menus (withMenu=true) were not clickable zones, forcing users to click only on the radio button or specific areas. Now, users can click anywhere on the card to select it, while menu button clicks are properly isolated using event propagation control.

Key Changes:

  • Removed conditional logic that disabled full-click zones when menus were present
  • Added isChildrenIndependent property to maintain menu button independence
  • Implemented stopPropagation() on all menu interactions to prevent unintended card selection

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/components/instances-view.tsx Removed conditional spread operator that disabled isFullClickZone when menu present; added isChildrenIndependent flag
src/components/players-view.tsx Applied same clickability improvements as instances view
src/components/instance-menu.tsx Added stopPropagation() to menu button and all menu items to prevent click bubbling
src/components/player-menu.tsx Added stopPropagation() to menu button and all menu items to prevent click bubbling
src/components/common/wrap-card.tsx Moved click handler from Radio button to parent Card for consistent click behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant