fix: Scroll page to where user is editing #680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Collaborator
How to solve this any solution? I am also facing the same. |
|
Possibly related - if you have a tall block with nested children, nesting a new child scrolls you to the top of the nested block, rather than keep the child you've just nested in view. |
# Conflicts: # packages/core/src/extensions/SuggestionMenu/SuggestionPlugin.ts
matthewlipski
changed the title
scrollIntoView issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user presses Enter to create a new block, or types in a block, and that block is below the viewport, it's not automatically scrolled to with
scrollIntoView. This PR fixes that.Seems like #656 was fixed at some point with the UI refactor, since I can't reproduce it anymore on 0.13.1.
Closes #656