Skip to content

Conversation

@matthewlipski
Copy link
Collaborator

This PR makes some small but useful changes for how text in the add block button & file panel is changed for file blocks. It's now done entirely through the dictionary, whereas it was previously split. The file panel text was set throught the dictionary, but the add block button text was set using a buttonText prop. The PDF block example has also been updated with this change.

@vercel
Copy link

vercel bot commented Sep 4, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
blocknote Ready Ready Preview Sep 4, 2025 2:29pm
blocknote-website Error Error Sep 4, 2025 2:29pm

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 4, 2025

Open in StackBlitz

@blocknote/ariakit

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/ariakit@1984

@blocknote/code-block

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/code-block@1984

@blocknote/core

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/core@1984

@blocknote/mantine

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/mantine@1984

@blocknote/react

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/react@1984

@blocknote/server-util

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/server-util@1984

@blocknote/shadcn

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/shadcn@1984

@blocknote/xl-ai

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-ai@1984

@blocknote/xl-docx-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-docx-exporter@1984

@blocknote/xl-email-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-email-exporter@1984

@blocknote/xl-multi-column

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-multi-column@1984

@blocknote/xl-odt-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-odt-exporter@1984

@blocknote/xl-pdf-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-pdf-exporter@1984

commit: 1eafda4

Copy link
Contributor

@nperez0111 nperez0111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change!

@matthewlipski
Copy link
Collaborator Author

@YousefED since the PDF block is a pro example, should we also add an example e.g. changing the text for image blocks to be “Add/Upload/Embed Photo”?

@YousefED
Copy link
Collaborator

YousefED commented Sep 5, 2025

@matthewlipski we don't need a separate example.

Thanks for this! Note that while the PR is a good improvement, this way of changing the dictionary doesn't really scale (i.e.: you can change some strings, but not icons etc.). I don't think this is a priority now, but good to keep in mind when we revisit UI Components

@matthewlipski matthewlipski merged commit c3422c2 into main Sep 5, 2025
7 of 8 checks passed
@matthewlipski matthewlipski deleted the file-block-dict branch September 5, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants