-
-
Notifications
You must be signed in to change notification settings - Fork 642
XL React Email Renderer #1768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XL React Email Renderer #1768
Conversation
|
@jmarbutt is attempting to deploy a commit to the TypeCell Team on Vercel. A member of the Team first needs to authorize it. |
YousefED
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome stuff, I dropped some notes that I hope are helpful!
examples/05-interoperability/08-converting-blocks-to-react-email/App.tsx
Outdated
Show resolved
Hide resolved
packages/xl-react-email-exporter/src/react-email/defaultSchema/blocks.tsx
Outdated
Show resolved
Hide resolved
packages/xl-react-email-exporter/src/react-email/defaultSchema/blocks.tsx
Outdated
Show resolved
Hide resolved
packages/xl-react-email-exporter/src/react-email/defaultSchema/blocks.tsx
Outdated
Show resolved
Hide resolved
packages/xl-react-email-exporter/src/react-email/reactEmailExporter.test.tsx
Outdated
Show resolved
Hide resolved
packages/xl-react-email-exporter/src/react-email/reactEmailExporter.test.tsx
Outdated
Show resolved
Hide resolved
packages/xl-react-email-exporter/src/react-email/reactEmailExporter.tsx
Outdated
Show resolved
Hide resolved
packages/xl-react-email-exporter/src/react-email/reactEmailExporter.tsx
Outdated
Show resolved
Hide resolved
packages/xl-react-email-exporter/src/react-email/defaultSchema/blocks.tsx
Outdated
Show resolved
Hide resolved
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
packages/xl-react-email-exporter/src/react-email/__snapshots__/reactEmailExporter.test.tsx.snap
Outdated
Show resolved
Hide resolved
packages/xl-react-email-exporter/src/react-email/defaultSchema/blocks.tsx
Outdated
Show resolved
Hide resolved
packages/xl-react-email-exporter/src/react-email/reactEmailExporter.tsx
Outdated
Show resolved
Hide resolved
packages/xl-react-email-exporter/src/react-email/defaultSchema/blocks.tsx
Outdated
Show resolved
Hide resolved
packages/xl-react-email-exporter/src/react-email/reactEmailExporter.tsx
Outdated
Show resolved
Hide resolved
packages/xl-react-email-exporter/src/react-email/reactEmailExporter.tsx
Outdated
Show resolved
Hide resolved
| ): Promise<React.ReactElement<any>[]> { | ||
| const nestedList: React.ReactElement<any>[] = []; | ||
| let i = 0; | ||
| while (i < children.length) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
nperez0111
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor code-style comments, but otherwise looks great. Good work on this!
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
Overview
This pull request introduces a new example for converting BlockNote documents into React Email documents, along with setup and dependencies for the
@blocknote/xl-react-email-exporterpackage. The changes include adding a complete example implementation, updating configurations, and creating the necessary package files for React Email integration.Example
I have setup the example in the examples folder to test with.
Implemented Rendering for
react-emailThis implementation is a first pass allowing exporting to react-email components to send via email. Most of the implementation was done originally in the branch https://github.com/TypeCellOS/BlockNote/tree/feature/react-email-exporter
...
', from what I can tell this is completely compatible with the react-email renderingpdfExporterBlocksto create the numbered list correctlyreact-emailcodeblock component which renders pretty nicely in the email.sectioncomponent fromreact-emailas their recommendation. But one thing you will find is it renders 1 table per row, which this created an issue with the alignment of columns. So I am currently setting adefaultColWidthbut a future enhancement may be to make that better