fix: Link UX #1304
Merged
fix: Link UX #1304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@matthewlipski this is amazing ! That would also close #522 :) |
YousefED
requested changes
Dec 5, 2024
YousefED
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses 2 UX issues with links:
Mod+K) toggles the link mark but doesn't open the link editing menu, so nohrefis set. This has been changed so the shortcut now just opens the link creation popover in the formatting toolbar. I think the only real flaw of this approach is that the formatting toolbar needs to be open for the shortcut to work, but otherwise imo the UX is good. This issue could also be fixed but I think it's a pretty unlikely scenario and fixing it would add fairly significant complexity.www.google.comwould redirect users to<protocol>://<current-domain>/www.google.cominstead ofhttps://www.google.com. This has been changed so that link URLs without a protocol are prefixed withhttp://when the user creates/updates a link.Closes #1141
Closes #552