Add a Mapping Processor Adapter #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turnerj
approved these changes
Oct 9, 2020
|
This is a good idea, implemented well. Thanks for contributing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to get your thoughts on this idea. It's a step towards #136 but I didn't like the idea of cluttering up DbSet or Context.
Plus, the definition seems to be created as late as possible (which makes sense), so trying to shoehorn some sort of OnModelCreating into the Context would deeply couple the Context and the Mapping.
This idea of a MappingAdapter would allow an entity to override all definitions at the point of creation without attributes (except of course for this one at the entity level). No dependency on Context or DbSet. Really, the adapter isn't even coupled to the class its adapting.
The processor for this runs last, so the adapter can override whatever it needs to.
This solves my immediate need of changing the entity definition without attributes.
As always, open to naming suggestions :)