Skip to content

Conversation

@Turnerj
Copy link
Member

@Turnerj Turnerj commented Oct 19, 2019

Closes #106

IndexModelBuilderBenchmark

Before

Method Mean Error StdDev Gen 0 Gen 1 Gen 2 Allocated
FlatModel 33.13 us 0.2674 us 0.2502 us 3.7842 - - 11.59 KB
NestedModel 37.18 us 0.4619 us 0.4094 us 4.9438 - - 15.15 KB

After

Method Mean Error StdDev Gen 0 Gen 1 Gen 2 Allocated
FlatModel 32.03 us 0.3295 us 0.2752 us 3.6621 - - 11.25 KB
NestedModel 35.67 us 0.3898 us 0.3646 us 4.6997 - - 14.5 KB

EntityMappingBenchmark

Before

Method Mean Error StdDev Gen 0 Gen 1 Gen 2 Allocated
ResetOverhead 973.1 ns 10.02 ns 9.369 ns 0.2346 - - 737 B
ClassMapAutoMap 26,108.3 ns 129.99 ns 108.549 ns 2.6550 - - 8373 B
EntityMappingRegister 98,133.5 ns 1,355.18 ns 1,267.632 ns 12.6953 - - 40571 B

After

Method Mean Error StdDev Gen 0 Gen 1 Gen 2 Allocated
ResetOverhead 991.8 ns 8.703 ns 8.141 ns 0.2346 - - 737 B
ClassMapAutoMap 26,475.4 ns 284.697 ns 266.306 ns 2.6550 - - 8373 B
EntityMappingRegister 46,178.4 ns 303.181 ns 283.596 ns 9.1553 - - 28906 B

@Turnerj Turnerj added enhancement Enhancements & features affects-serialization Serialization-related issue moderate-change Moderate changes required labels Oct 19, 2019
@codecov
Copy link

codecov bot commented Oct 19, 2019

Codecov Report

Merging #107 into master will increase coverage by 0.24%.
The diff coverage is 96.1%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
+ Coverage   91.54%   91.78%   +0.24%     
==========================================
  Files          71       70       -1     
  Lines        2447     2447              
  Branches      322      326       +4     
==========================================
+ Hits         2240     2246       +6     
+ Misses        137      131       -6     
  Partials       70       70
Impacted Files Coverage Δ
...frastructure/Mapping/EntityDefinitionExtensions.cs 98.71% <100%> (ø) ⬆️
...cture/Mapping/Processors/ExtraElementsProcessor.cs 100% <100%> (ø) ⬆️
.../Mapping/Processors/EntityRelationshipProcessor.cs 95.23% <100%> (-1.06%) ⬇️
...oFramework/Infrastructure/Mapping/EntityMapping.cs 82.89% <100%> (-0.65%) ⬇️
...ework/Infrastructure/Mapping/DefaultMappingPack.cs 100% <100%> (ø) ⬆️
...tructure/Mapping/Processors/NestedTypeProcessor.cs 100% <100%> (ø) ⬆️
...astructure/Mapping/Processors/EntityIdProcessor.cs 93.93% <91.66%> (-2.22%) ⬇️
...ure/Mapping/Processors/PropertyMappingProcessor.cs 97.36% <97.36%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 273d441...7910bd2. Read the comment docs.

@Turnerj Turnerj merged commit a929aff into master Oct 19, 2019
@Turnerj Turnerj deleted the drop-bsonclassmap-automap branch October 19, 2019 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

affects-serialization Serialization-related issue enhancement Enhancements & features moderate-change Moderate changes required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove BsonClassMap.AutoMap from Mapping Registration Process

2 participants